Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure addon integrity by adding sha256 checksums to images #10527

Merged
merged 1 commit into from
Feb 20, 2021
Merged

Ensure addon integrity by adding sha256 checksums to images #10527

merged 1 commit into from
Feb 20, 2021

Conversation

medyagh
Copy link
Member

@medyagh medyagh commented Feb 20, 2021 •
edited
Loading

this PR

  • adds sha to all addons
  • removes the latest from the ones that have a tag we could use

closes #9884

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 20, 2021
@medyagh
Copy link
Member Author

medyagh commented Feb 20, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [medyagh,sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 10527): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10527/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10527/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 10527): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/10527/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/10527/minikube: exec format error

@medyagh medyagh merged commit ea4aaca into kubernetes:master Feb 20, 2021
@medyagh medyagh changed the title add sha to all addons Esnure addon integrity by adding Image SHA Feb 20, 2021
@medyagh medyagh deleted the addon_shas branch March 2, 2021 21:28
@tstromberg tstromberg changed the title Esnure addon integrity by adding Image SHA Ensure addon integrity by adding sha256 checksums to images Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharifelgamal sharifelgamal sharifelgamal approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add SHA image for addons
4 participants
@medyagh @k8s-ci-robot @minikube-pr-bot @sharifelgamal